hhr293 commented on PR #12756: URL: https://github.com/apache/gluten/pull/12756#issuecomment-5504652874
Hi @FelixYBW @LuciferYang @beliefer @zhouyuan , I’ve completed the follow-up validation and review changes. Could you please take another look? Submitted the Spark-side draft PR: apache/spark#58424. The rule remains default-off, and the upstream validation is complete. I also validated the rule with default-on and regenerated the Q95 golden plans. The related CI run is here: https://github.com/hhr293/spark/actions/runs/33462355553 One of the current CI failures is infrastructure-related rather than test-related: Maven failed to download apache-maven-3.9.16-bin.tar.gz from Maven Central and exited before running the tests. Addressed the comparePlans suggestion in 9b6ed299 by comparing the rewritten plans against equivalent hand-written aggregate SQL. Thanks for the reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
