hhr293 commented on code in PR #12756:
URL: https://github.com/apache/gluten/pull/12756#discussion_r3931157894
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -918,6 +921,17 @@ object VeloxConfig extends ConfigRegistry {
.booleanConf
.createWithDefault(false)
+ val ENABLE_REWRITE_SELF_JOIN_INEQUALITY =
+ buildConf("spark.gluten.sql.rewrite.selfJoinInequality")
Review Comment:
Yeah, this is deliberate.
I’d like to keep spark.gluten.sql.rewrite.selfJoinInequality public but
default-off, so users can explicitly opt in while the rule gets broader
workload coverage. That is also why it is documented in velox-configuration.md.
So I would prefer not to mark it .internal() at this stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
