LuciferYang commented on code in PR #12954:
URL: https://github.com/apache/gluten/pull/12954#discussion_r3950244095
##########
shims/common/src/main/scala/org/apache/gluten/execution/datasource/GlutenFormatWriterInjects.scala:
##########
@@ -76,13 +76,6 @@ object GlutenFormatFactory {
postRuleFactory = factory
}
Review Comment:
Still true, and still deliberate. Nothing reads `postRuleFactory` now that
`getExtendedColumnarPostRules` is gone.
I re-checked the cascade before leaving it: dropping the setter orphans
`GlutenWriterColumnarRules.NativeWritePostRule`, which orphans the private
`getNativeFormat`, which orphans `BackendSettingsApi.skipNativeCtas` and
`skipNativeInsertInto` plus their two `VeloxBackend` overrides. Six files, and
two of them are members of a backend-facing trait. `VeloxListenerApi` still
carries an `Only register NativeWritePostRule for Spark 3.3` guard right next
to the registration, so that whole path belongs to the follow-up that clears
the residual 3.3 version checks, and it goes as one piece there rather than
half here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
