jackylee-ch commented on code in PR #12954:
URL: https://github.com/apache/gluten/pull/12954#discussion_r3954363533
##########
shims/common/src/main/scala/org/apache/gluten/sql/shims/SparkShims.scala:
##########
@@ -85,67 +79,23 @@ trait SparkShims {
def runtimeReplaceableExpressionMappings: Seq[Sig]
- def generateFileScanRDD(
- sparkSession: SparkSession,
- readFunction: PartitionedFile => Iterator[InternalRow],
- filePartitions: Seq[FilePartition],
- fileSourceScanExec: FileSourceScanExec): FileScanRDD
-
def filesGroupedToBuckets(
selectedPartitions: Array[PartitionDirectory]): Map[Int,
Array[PartitionedFile]]
- // Spark3.4 new add table parameter in BatchScanExec.
- def getBatchScanExecTable(batchScan: BatchScanExec): Table
-
- // The PartitionedFile API changed in spark 3.4
- def generatePartitionedFile(
- partitionValues: InternalRow,
- filePath: String,
- start: Long,
- length: Long,
- @transient locations: Array[String] = Array.empty): PartitionedFile
-
def isWindowGroupLimitExec(plan: SparkPlan): Boolean = false
def getWindowGroupLimitExecShim(plan: SparkPlan): WindowGroupLimitExecShim =
null
def getWindowGroupLimitExec(windowGroupLimitExecShim:
WindowGroupLimitExecShim): SparkPlan = null
- def getLimitAndOffsetFromGlobalLimit(plan: GlobalLimitExec): (Int, Int) =
(plan.limit, 0)
-
- def getLimitAndOffsetFromTopK(plan: TakeOrderedAndProjectExec): (Int, Int) =
(plan.limit, 0)
-
- def getExtendedColumnarPostRules(): List[SparkSession => Rule[SparkPlan]]
-
def writeFilesExecuteTask(
Review Comment:
The `writeFilesExecuteTask` seems can also be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
