Copilot commented on code in PR #13118:
URL: https://github.com/apache/gluten/pull/13118#discussion_r4093384904
##########
dev/vcpkg/setup-build-depends.sh:
##########
@@ -172,18 +186,19 @@ install_centos_9() {
pip3 install --upgrade pip
-
dnf -y --enablerepo=crb install autoconf-archive ninja-build
+ install_ccache
Review Comment:
`install_centos_9` now calls `install_ccache`, whose implementation requires
the `curl` executable, but this function's package list does not install curl.
The CentOS 9 Docker path also starts from an image that only installs the
distro ccache package, so this can fail with `curl: command not found`; add
curl to the CentOS 9 prerequisites (or use the already-installed wget
consistently).
##########
ep/build-velox/src/setup-openeuler24.sh:
##########
@@ -52,21 +52,32 @@ DUCKDB_VERSION="v0.8.1"
GEOS_VERSION="3.10.7"
ABSEIL_VERSION="20240116.2"
GRPC_VERSION="v1.48.1"
+CCACHE_VERSION="4.14"
function dnf_install {
dnf install -y -q --setopt=install_weak_deps=False "$@"
}
+function install_ccache {
+ # Static (musl) build: no glibc requirement, available for x86_64 and
aarch64.
+ local name="ccache-${CCACHE_VERSION}-linux-$(uname -m)-musl-static"
+ curl -fsSL
"https://github.com/ccache/ccache/releases/download/v${CCACHE_VERSION}/${name}.tar.gz";
-o "/tmp/${name}.tar.gz"
+ tar -xzf "/tmp/${name}.tar.gz" -C /tmp
+ ${SUDO:-} install -m 0755 "/tmp/${name}/ccache" /usr/local/bin/ccache
+ rm -rf "/tmp/${name}" "/tmp/${name}.tar.gz"
+}
+
# Install packages required for build.
function install_build_prerequisites {
dnf update -y
- dnf_install dnf-plugins-core # For ccache, ninja
+ dnf_install dnf-plugins-core # For ninja
dnf update -y
- dnf_install ninja-build cmake ccache gcc g++ git wget which patch
+ dnf_install ninja-build cmake gcc g++ git wget which patch
Review Comment:
This new installer invokes `curl`, but the openEuler prerequisite list does
not install it. On a minimal openEuler host, `install_build_prerequisites` will
therefore abort at the next line with `curl: command not found`; add `curl` to
this package list (or download with the already-installed `wget`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
