Copilot commented on code in PR #13118:
URL: https://github.com/apache/gluten/pull/13118#discussion_r4093433231
##########
dev/vcpkg/setup-build-depends.sh:
##########
@@ -19,10 +19,21 @@ set -e
## Install functions begin
+CCACHE_VERSION="4.14"
+
function semver {
echo "$@" | awk -F. '{ printf("%d%03d%03d", $1,$2,$3); }'
}
+install_ccache() {
+ # Static (musl) build: no glibc requirement, available for x86_64 and
aarch64.
+ local name="ccache-${CCACHE_VERSION}-linux-$(uname -m)-musl-static"
Review Comment:
This helper is used by the generic vcpkg installer, while the repository
still supports `ppc64le` (`dev/package.sh:28-31` and
`ep/build-velox/src/build-velox.sh:205`). Because the static release is
documented here as available only for x86_64/aarch64, `uname -m` becomes
`ppc64le` and this constructs an unavailable download URL, regressing that
platform from the distro ccache that was previously installed. Keep a
package-manager fallback for unsupported architectures or reject them before
replacing the package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
