LuciferYang commented on code in PR #13143:
URL: https://github.com/apache/gluten/pull/13143#discussion_r4111156921
##########
gluten-core/src/main/scala/org/apache/gluten/extension/columnar/transition/Transition.scala:
##########
@@ -93,11 +92,6 @@ object Transition {
}
}
Review Comment:
Keeping the removal. `Transition.Factory` lives in the internal
`org.apache.gluten.extension.columnar.transition` package and is
transition-graph plumbing, not a documented extension point — extensions are
wired through the injector rules and `Component`, not by calling
`Transition.factory` directly. `satisfies` has zero callers across all backends
in-tree, and Gluten does not guarantee binary compatibility for these internal
APIs across versions, so removing an unused internal method is in line with the
project's practice. Happy to restore or `@deprecated`-tag it instead if a
maintainer considers this a supported surface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
