jackylee-ch commented on code in PR #13145:
URL: https://github.com/apache/gluten/pull/13145#discussion_r4129182669


##########
gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala:
##########
@@ -116,7 +116,7 @@ private object GlutenDriverPlugin extends Logging {
         if (conf.contains(GlutenCoreConfig.SPARK_OFFHEAP_ENABLED_KEY)) {
           logWarning(
             s"Dynamic off-heap sizing is enabled. Ignoring user-defined " +
-              s"'${GlutenCoreConfig.SPARK_OFFHEAP_SIZE_KEY}' setting.")
+              s"'${GlutenCoreConfig.SPARK_OFFHEAP_ENABLED_KEY}' setting.")

Review Comment:
   `SPARK_OFFHEAP_SIZE_KEY` is the correct key here. The logic would ignore 
user defined `SPARK_OFFHEAP_SIZE`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to