LuciferYang commented on code in PR #13145:
URL: https://github.com/apache/gluten/pull/13145#discussion_r4130856890
##########
gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala:
##########
@@ -116,7 +116,7 @@ private object GlutenDriverPlugin extends Logging {
if (conf.contains(GlutenCoreConfig.SPARK_OFFHEAP_ENABLED_KEY)) {
logWarning(
s"Dynamic off-heap sizing is enabled. Ignoring user-defined " +
- s"'${GlutenCoreConfig.SPARK_OFFHEAP_SIZE_KEY}' setting.")
+ s"'${GlutenCoreConfig.SPARK_OFFHEAP_ENABLED_KEY}' setting.")
Review Comment:
This warning is guarded by `conf.contains(SPARK_OFFHEAP_ENABLED_KEY)`, and
this branch sets `SPARK_OFFHEAP_ENABLED_KEY` to `false`, so the setting being
ignored here is the enabled flag. The size setting is covered by the next `if
(conf.contains(SPARK_OFFHEAP_SIZE_KEY))` block, which still names
`SPARK_OFFHEAP_SIZE_KEY`. With the old text, a user who set only
`spark.memory.offHeap.enabled` and no size would get a warning about
`spark.memory.offHeap.size`, which they never configured. Happy to reconsider
if you meant changing the guard rather than the message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
