yikf commented on code in PR #13115:
URL: https://github.com/apache/gluten/pull/13115#discussion_r4269135115
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxListenerApi.scala:
##########
@@ -317,6 +317,18 @@ object VeloxListenerApi {
parsed += (COLUMNAR_VELOX_CACHE_ENABLED.key -> "false")
}
+ // The broadcast hash-table build thread pool is sized from
numTaskSlotsPerExecutor by default,
+ // which is derived from executor cores. On the driver, this would
misreport the available
+ // parallelism: driver-side hash-table build runs in the driver JVM and
should be bounded by
+ // spark.driver.cores. Only override when the user has not pinned the
thread count explicitly.
+ if (
+ isDriver && !inLocalMode(conf) &&
+ !parsed.contains(COLUMNAR_VELOX_BROADCAST_HASH_TABLE_BUILD_THREADS.key)
+ ) {
+ val driverCores = SparkResourceUtil.getDriverCores(conf)
+ parsed += (COLUMNAR_VELOX_BROADCAST_HASH_TABLE_BUILD_THREADS.key ->
driverCores.toString)
+ }
Review Comment:
make sense to me. updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
