maoyuwei1 commented on PR #13283:
URL: https://github.com/apache/gluten/pull/13283#issuecomment-6189493408
Thanks for the detailed review, @kerwin-zk — you're right, assigning to the
parameter
only rebound a local reference, so the manager field stayed null and the
cleaner's
scheduled executor was never stopped.
I've pushed a follow-up commit (f9c8f8d):
- `fetchCleanFailedShuffle` and `stageRerun` now return the created
`FailedShuffleCleaner` (null when disabled/absent), and
`CelebornShuffleManager.initializeLifecycleManager()` stores it in its
`failedShuffleCleaner` field, so `stop()` properly calls
`stopFailedShuffleCleaner`.
- Added `CelebornUtilsTest` with a regression test that enables
`celeborn.client.spark.fetch.cleanFailedShuffle` and verifies both
construction and
shutdown of the cleaner, plus unit tests for the constructor-matching logic
(overload selection, subtype/null arguments, primitive mismatch, missing
class).
PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
