maoyuwei1 commented on PR #13283: URL: https://github.com/apache/gluten/pull/13283#issuecomment-6209975501
@kerwin-zk Thanks, both points are valid. The test no longer constructs a real LifecycleManager: it uses a mocked one (so no RpcEnv/ApplicationHeartbeater, no RPC to any master) and a new CelebornConf(false) so ambient celeborn.* system properties cannot leak in. The cleaner is now always stopped in finally, and shutdown is actually asserted: the test captures the cleaner’s ExecutorService, asserts it is live before stopFailedShuffleCleaner, and asserts isShutdown() + awaitTermination(...) afterwards. Ownership is still verified via verify(...) on the two LifecycleManager callback registrations. The suite now runs in ~2.3s with no master-connection logs, and I confirmed the new assertions fail if either the ownership fix or the stop call is reverted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
