luis4a0 commented on code in PR #13103: URL: https://github.com/apache/gluten/pull/13103#discussion_r4281933212
########## ep/build-velox/src/get-velox.sh: ########## @@ -25,7 +25,7 @@ RUN_SETUP_SCRIPT=ON ENABLE_ENHANCED_FEATURES=OFF # Developer use only for testing Velox PR. -UPSTREAM_VELOX_PR_ID="" +UPSTREAM_VELOX_PR_ID="19141" Review Comment: This repeats the dependency/merge gate already tracked at https://github.com/apache/gluten/pull/13103#discussion_r4269051542 . The existing response explains why this validation revision deliberately exercises the upstream PR and why the hook must be restored to its empty default once a qualified normal dependency contains the fix. Closing this duplicate discussion only; the original dependency thread remains open and the merge requirement is unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
