luis4a0 commented on code in PR #13282:
URL: https://github.com/apache/gluten/pull/13282#discussion_r4283474969
##########
cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc:
##########
@@ -127,6 +127,15 @@ bool SubstraitToVeloxPlanValidator::validateRound(
return false;
}
+ const auto& scale = arguments[1].value().literal();
+ if (scale.has_null() && scale.null().has_i32()) {
+ const auto& valueType = params[0]->type();
+ if (!valueType->isDecimal() &&
+ (valueType->isTinyint() || valueType->isSmallint() ||
valueType->isInteger() || valueType->isBigint())) {
+ return true;
+ }
+ }
Review Comment:
This repeats the already-checked invariant discussion at
https://github.com/apache/gluten/pull/13282#discussion_r4281934039 . The
private helper's sole caller builds the argument-aligned vector from successful
non-null conversions, and failures cannot continue into this helper. The
existing arity guard is sufficient under that contract, which is now
documented. Closing this repeated warning; the caller/converter reasoning and
source links remain in the original explanation.
##########
ep/build-velox/src/get-velox.sh:
##########
@@ -25,7 +25,7 @@ RUN_SETUP_SCRIPT=ON
ENABLE_ENHANCED_FEATURES=OFF
# Developer use only for testing Velox PR.
-UPSTREAM_VELOX_PR_ID=""
+UPSTREAM_VELOX_PR_ID="19480"
Review Comment:
Tracked by the original dependency/merge-gate thread:
https://github.com/apache/gluten/pull/13282#discussion_r4269051013 . The hook
is deliberately temporary for upstream-change validation, and must be cleared
after qualifying a normal dependency containing that implementation. Closing
this duplicate only; the original pre-merge gate remains open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
