infvg commented on code in PR #12964:
URL: https://github.com/apache/gluten/pull/12964#discussion_r4313212544
##########
gluten-iceberg/src/main/scala/org/apache/gluten/execution/IcebergScanTransformer.scala:
##########
@@ -216,13 +208,28 @@ case class IcebergScanTransformer(
!readSchemaFields.contains(name)
}
+ private lazy val copyOnWriteFilePathMetadataColumns = output.filter {
+ attr => IcebergScanTransformer.isCopyOnWriteFilePathColumn(attr.name)
+ }
+
override def getMetadataColumns(): Seq[AttributeReference] = {
- val extraMetadataColumns = inputFileRelatedMetadataColumns.filterNot {
- metadataAttr =>
metadataColumns.exists(_.name.equalsIgnoreCase(metadataAttr.name))
- }
+ val extraMetadataColumns =
+ (inputFileRelatedMetadataColumns ++
copyOnWriteFilePathMetadataColumns).filterNot {
+ metadataAttr =>
metadataColumns.exists(_.name.equalsIgnoreCase(metadataAttr.name))
+ }
metadataColumns ++ extraMetadataColumns
}
+ override protected def isRowIndexMetadataColumn(attr: Attribute): Boolean = {
+ IcebergScanTransformer.isCopyOnWriteRowPositionColumn(attr.name) ||
+ super.isRowIndexMetadataColumn(attr)
+ }
+
+ override protected def isNativeMetadataColumn(attr: Attribute): Boolean = {
+ IcebergScanTransformer.isCopyOnWriteFilePathColumn(attr.name) ||
+ super.isNativeMetadataColumn(attr)
+ }
Review Comment:
Covered by upstream tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
