infvg commented on code in PR #12964:
URL: https://github.com/apache/gluten/pull/12964#discussion_r4313280291
##########
.github/workflows/util/iceberg-upstream/flaky-tests.csv:
##########
@@ -16,5 +16,7 @@
# All invocations of these methods run and are reported, but do not affect the
gate.
# Use exact class and method names; omit method arguments and invocation
indices.
class,method
-# Example
-#
org.apache.iceberg.spark.extensions.TestAlterTablePartitionFields,testDropPartitionAndSourceColumnLong
+# Tests expect BatchScanExec, native uses IcebergScanTransformer soo these
fail.
Review Comment:
fixed
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/BasicScanExecTransformer.scala:
##########
@@ -177,12 +177,20 @@ trait BasicScanExecTransformer extends
LeafTransformSupport with BaseDataSource
doNativeValidation(substraitContext, relNode)
}
+ protected def isRowIndexMetadataColumn(attr: Attribute): Boolean = {
+
BackendsApiManager.getSparkPlanExecApiInstance.isRowIndexMetadataColumn(attr.name)
+ }
+
+ protected def isNativeMetadataColumn(attr: Attribute): Boolean = {
+ attr.isMetadataCol || getMetadataColumns().exists(_.exprId == attr.exprId)
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
