philo-he commented on code in PR #13368:
URL: https://github.com/apache/gluten/pull/13368#discussion_r4395145723
##########
cpp/velox/jni/VeloxJniWrapper.cc:
##########
@@ -1138,7 +1138,7 @@ JNIEXPORT jlong JNICALL
Java_org_apache_gluten_vectorized_HashJoinBuilder_native
facebook::velox::exec::BaseHashTable::kNoSpillInputStartPartitionBit,
hashTableBuilders[0]->joinBuildVectorHasherMaxNumDistinct(),
hashTableBuilders[0]->dropDuplicates(),
- allowParallelJoinBuild ?
VeloxBackend::get()->broadcastHashTableBuildExecutor() : nullptr);
+ allowParallelJoinBuild ? executor : nullptr);
Review Comment:
Nit:
My understanding is, executor will be nullptr for serial build
(allowParallelJoinBuild is false). If so,
it seems that we can just use `executor` as the arg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
