zhztheplayer commented on code in PR #13368:
URL: https://github.com/apache/gluten/pull/13368#discussion_r4405280390
##########
cpp/velox/jni/VeloxJniWrapper.cc:
##########
@@ -1022,10 +1022,11 @@ JNIEXPORT jlong JNICALL
Java_org_apache_gluten_vectorized_HashJoinBuilder_native
cb.push_back(ObjectStore::retrieve<ColumnarBatch>(handle));
}
- if (numThreads == 1) {
- // Use default global pool for driver-side build
- // The hash table will be serialized and broadcast, so it doesn't need
runtime's pool
- // Using runtime pool causes lifecycle management issues
+ auto* executor = VeloxBackend::get()->broadcastHashTableBuildExecutor();
+ if (numThreads == 1 || executor == nullptr) {
Review Comment:
Is this review comment valid? Doc says "A value less than or equal to one
uses the serial build path without creating a dedicated thread pool. "
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
