ggjh-159 commented on code in PR #13461:
URL: https://github.com/apache/gluten/pull/13461#discussion_r4396531146
##########
gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/functions/RexCallConverterFactory.java:
##########
@@ -111,6 +111,11 @@ public class RexCallConverterFactory {
Map.entry("count_char", Arrays.asList(() -> new
DefaultRexCallConverter("count_char"))),
Map.entry("EXTRACT", Arrays.asList(() -> new
DefaultRexCallConverter("extract"))),
Map.entry("IS TRUE", Arrays.asList(() -> new
IsTrueRexCallConverter())),
Review Comment:
The IS TRUE entry maps to `equalto(x, true)`, which returns NULL for a NULL
input, while Flink `x IS TRUE` returns FALSE and never NULL
(`ScalarOperatorGens.scala:771-777`, NEVER_NULL). Switch this entry to the
flinksql `is_true` function once it is available, and include IS TRUE in the
SQL-level tests, asserting FALSE for NULL input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
