sunshone commented on code in PR #13461:
URL: https://github.com/apache/gluten/pull/13461#discussion_r4411712060
##########
gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/functions/RexCallConverterFactory.java:
##########
@@ -111,6 +111,11 @@ public class RexCallConverterFactory {
Map.entry("count_char", Arrays.asList(() -> new
DefaultRexCallConverter("count_char"))),
Map.entry("EXTRACT", Arrays.asList(() -> new
DefaultRexCallConverter("extract"))),
Map.entry("IS TRUE", Arrays.asList(() -> new
IsTrueRexCallConverter())),
Review Comment:
Switched the IS TRUE entry to DefaultRexCallConverter("is_true") now that the
flinksql is_true function is available (velox PR bigo-sg/velox#90).
IsTrueRexCallConverter itself is pre-existing baseline code, so it is left
untouched.
The SQL-level tests assert FALSE for a NULL input
(LogicalFunctionsTest.testIsTrue over a boolean column containing NULLs), and
a cluster-level dual-run of the same query on native Flink and GlutenFlink
produces identical results, with the NULL row evaluating to false on both
sides and never to NULL. Commit: d98b36423.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
