LuciferYang opened a new pull request, #13482: URL: https://github.com/apache/gluten/pull/13482
## What changes are proposed in this pull request? `framedSerializeWithStats`, which writes the V2 table cache frame, marshaled the partition stats blob inline. That code was the same as `buildStatsBlob`, which the V3 frame already uses, apart from braces and how declarations were grouped. This calls `buildStatsBlob` instead and removes the inline copy, so the stats wire format is defined in one place. The comments that only existed in the V2 copy move into `buildStatsBlob`: what `count` means, the HUGEINT byte order, the VARCHAR truncation note, and why the timestamp upper bound is rounded up. They replace a comment there that pointed back to `framedSerializeWithStats`. A test comment now names `buildStatsBlob` instead of `marshalStatsInto`, which does not exist. Fixes #13481. ## How was this patch tested? No new tests. The existing `framedSerializeWithStats*` tests in `VeloxColumnarBatchSerializerTest` check the V2 frame layout and the stats bytes. With V3 disabled through `withStatsExtV3AvailabilityForBenchmark(false)`, the V2 and V3 stats rows for 13 column types (integers, floating point with NaN and nulls, strings, timestamp, boolean, decimals, date, and a partly null column) match before and after this change. ## Was this patch authored or co-authored using generative AI tooling? Yes. Generated-by: Claude Opus. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
