Copilot commented on code in PR #13131:
URL: https://github.com/apache/gluten/pull/13131#discussion_r4405029685
##########
.github/workflows/util/delta-spark-ut/java-test-args.sh:
##########
@@ -57,4 +67,16 @@ export
JAVA_TOOL_OPTIONS="${JAVA_TOOL_OPTIONS:+${JAVA_TOOL_OPTIONS} }\
--add-opens=java.base/sun.util.calendar=ALL-UNNAMED \
-Djdk.reflect.useDirectMethodHandle=false \
-Dio.netty.tryReflectionSetAccessible=true \
--Dfile.encoding=UTF-8"
+-Dfile.encoding=UTF-8 \
+-Dspark.plugins=org.apache.gluten.GlutenPlugin \
+-Dspark.shuffle.manager=org.apache.spark.shuffle.sort.ColumnarShuffleManager \
Review Comment:
`java-test-args.sh` describes these as *defaults*, but the current
construction appends them after any pre-existing `JAVA_TOOL_OPTIONS`, making
them override caller-provided environment settings. To preserve “default”
semantics (overrideable by users/CI overrides), build `JAVA_TOOL_OPTIONS` so
existing values come last (or only append each `-D...` if it isn’t already
present).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
