felipepessoto commented on code in PR #13131:
URL: https://github.com/apache/gluten/pull/13131#discussion_r4405254930
##########
.github/workflows/util/delta-spark-ut/java-test-args.sh:
##########
@@ -57,4 +67,16 @@ export
JAVA_TOOL_OPTIONS="${JAVA_TOOL_OPTIONS:+${JAVA_TOOL_OPTIONS} }\
--add-opens=java.base/sun.util.calendar=ALL-UNNAMED \
-Djdk.reflect.useDirectMethodHandle=false \
-Dio.netty.tryReflectionSetAccessible=true \
--Dfile.encoding=UTF-8"
+-Dfile.encoding=UTF-8 \
+-Dspark.plugins=org.apache.gluten.GlutenPlugin \
+-Dspark.shuffle.manager=org.apache.spark.shuffle.sort.ColumnarShuffleManager \
Review Comment:
Fixed in
[088abd652](https://github.com/apache/gluten/commit/088abd652e6e75cdfdb017085a2c325050b2e7fb).
Existing `JAVA_TOOL_OPTIONS` now come after the shared defaults, so
caller-supplied `-D` properties take precedence. The default configuration is
unchanged when the variable is unset or empty. I also documented the ordering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
