wud-if commented on PR #13455: URL: https://github.com/apache/gluten/pull/13455#issuecomment-6577786361
@philo-he Thanks for the review! All three addressed in a96247c. - **The committed taskmanager.out**: yes, a test-log capture that slipped in with content from an unrelated run — removed. - **Unified commit-hash maintenance**: the velox4j commit now lives in the single file `gluten-flink/velox4j-ref.txt`, and both the CI workflow and the build guide read it from there directly — updating the pin is a one-line edit to that file: no pre-build step, every reference stays consistent. - **CURRENT_TIME comparison flakiness**: kept evaluating CURRENT_TIME in SQL as suggested, but with inclusive full-day bounds — `CURRENT_TIME >= TIME '00:00:00' AND CURRENT_TIME <= TIME '23:59:59.999'` (the test projects both comparisons as separate columns) — always true at any run time, so no midnight flip. Verified against the full stack (velox at the current flinksql head): CurrentTimeFunctionsTest 2/2 and CurrentDateFunctionsTest 1/1 green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
