zhztheplayer commented on code in PR #12647:
URL: https://github.com/apache/gluten/pull/12647#discussion_r4525769051
##########
backends-velox/src-delta4/main/scala/org/apache/spark/sql/delta/GlutenOptimisticTransaction.scala:
##########
@@ -175,7 +181,8 @@ class GlutenOptimisticTransaction(delegate:
OptimisticTransaction)
if (nativeUnsupportedReason.isEmpty) {
GlutenDeltaFileFormatWriter.write(
sparkSession = spark,
- plan = glutenPhysicalPlan(spark, empty2NullPlan, constraints,
isOptimize, writeOptions),
+ plan = glutenPhysicalPlan(
+ spark, empty2NullPlan, constraints, nativeInvariantChecker,
isOptimize, writeOptions),
Review Comment:
nit: Can we create the `nativeInvariantChecker` inside the
`glutenPhysicalPlan` method? As we already passed `constraints` here, to reduce
the overlapping among the arguments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
