philo-he commented on PR #13502:
URL: https://github.com/apache/gluten/pull/13502#issuecomment-6847656096

   Thanks for the work! Since this makes default Delta 4.4 partitioned writes 
native, I have two concerns about the known gaps that now reach a default path:
   
   1. Per the description, `replaceWhere` and CHECK / NOT NULL violations on 
these writes lose Delta's exception type until #13133 lands (hence the 8 
restored known failures). That's a user-visible change for any partitioned 
table on Delta 4.4. Could we merge #13133 first, or keep materialized partition 
writes falling back until it's in? The combined validation in the description 
suggests the two work well together.
   
   2. The restored `OPTIMIZE` known failures show that partitioned writes to a 
filesystem Velox doesn't support now fail instead of falling back. Should this 
wait for the filesystem check in #13386, or at least be listed in the docs' 
known problems?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to