philo-he commented on code in PR #13502: URL: https://github.com/apache/gluten/pull/13502#discussion_r4560915722
########## docs/backends/velox/get-started/VeloxDelta.md: ########## @@ -198,7 +214,11 @@ The node also shows when Velox writes no data files. This happens for a DELETE t The Status column assumes Spark 3.5 or 4.x with native write on and ANSI mode off. On Spark 4.x, an Offload write still falls back in the cases in [Native write on Spark 4.x](#native-write-on-spark-4x). Otherwise every row is at best PartialOffload. In PartialOffload rows, Delta writes the files and the query that feeds the write can run in Velox. -Gluten's CI checks that a partitioned `save(path)` on 3.5 to 4.1 and OPTIMIZE on 3.5 run as Gluten native write commands. It also checks on 3.5 and 4.0 that a DELETE that rewrites a file runs in Gluten's transaction and that its scan runs in Velox. On 3.5 and 4.0, the copied Delta Lake suites also run UPDATE, DELETE, `save(path)` and `CREATE TABLE ... AS SELECT` with native write on. They check results only. On 4.1, the nightly job shows every Offload row except DELETE going through Velox's writer. The other Offload cases are from code. +Gluten's CI checks that partitioned `save(path)` and `OPTIMIZE` run as Gluten native write commands on Spark 3.5, 4.0, 4.1 and 4.2. The Spark 4.x jobs explicitly select `DeltaNativeWriteSuite`. CI also checks on 3.5 and 4.0 that a DELETE that rewrites a file runs in Gluten's transaction and that its scan runs in Velox. On 3.5 and 4.0, the copied Delta Lake suites also run UPDATE, DELETE, `save(path)` and `CREATE TABLE ... AS SELECT` with native write on. They check results only. On 4.1, the nightly job shows every Offload row except DELETE going through Velox's writer. The other Offload cases are from code. Review Comment: Nit: could we wrap this line (and line 215) at ~100 characters? With short lines, changing one word only shows up as one changed line in the diff, so review and `git blame` stay easy. It's also easier to read in IDEs and editors that don't soft-wrap Markdown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
