This is an automated email from the ASF dual-hosted git repository.

suvasude pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 28dcd62  [GOBBLIN-740][GOBBLIN-741][GOBBLIN-719] Remove setting 
retentionPolicy on every Point write
28dcd62 is described below

commit 28dcd62e9d2041969b041de104f5242150f95a06
Author: Jay Sen <[email protected]>
AuthorDate: Tue Jul 30 10:28:42 2019 -0700

    [GOBBLIN-740][GOBBLIN-741][GOBBLIN-719] Remove setting retentionPolicy on 
every Point write
    
    Closes #2607 from jhsenjaliya/GOBBLIN-740
---
 .../java/org/apache/gobblin/metrics/influxdb/InfluxDBPusher.java    | 6 ++----
 .../test/java/org/apache/gobblin/metrics/influxdb/TestInfluxDB.java | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git 
a/gobblin-modules/gobblin-metrics-influxdb/src/main/java/org/apache/gobblin/metrics/influxdb/InfluxDBPusher.java
 
b/gobblin-modules/gobblin-metrics-influxdb/src/main/java/org/apache/gobblin/metrics/influxdb/InfluxDBPusher.java
index 8c82d44..3821757 100644
--- 
a/gobblin-modules/gobblin-metrics-influxdb/src/main/java/org/apache/gobblin/metrics/influxdb/InfluxDBPusher.java
+++ 
b/gobblin-modules/gobblin-metrics-influxdb/src/main/java/org/apache/gobblin/metrics/influxdb/InfluxDBPusher.java
@@ -33,8 +33,6 @@ import org.influxdb.dto.Point;
  */
 public class InfluxDBPusher {
 
-  private static final String DEFAULT_RETENTION_POLICY = "default";
-
   private final InfluxDB influxDB;
   private final String database;
 
@@ -84,7 +82,7 @@ public class InfluxDBPusher {
    * @param point the {@link Point} to report
    */
   public void push(Point point) {
-    BatchPoints.Builder batchPointsBuilder = 
BatchPoints.database(database).retentionPolicy(DEFAULT_RETENTION_POLICY);
+    BatchPoints.Builder batchPointsBuilder = BatchPoints.database(database);
     batchPointsBuilder.point(point);
     influxDB.write(batchPointsBuilder.build());
   }
@@ -94,7 +92,7 @@ public class InfluxDBPusher {
    * @param points list of {@link Point}s to report
    */
   public void push(List<Point> points) {
-    BatchPoints.Builder batchPointsBuilder = 
BatchPoints.database(database).retentionPolicy(DEFAULT_RETENTION_POLICY);
+    BatchPoints.Builder batchPointsBuilder = BatchPoints.database(database);
     for (Point point : points) {
       batchPointsBuilder.point(point);
     }
diff --git 
a/gobblin-modules/gobblin-metrics-influxdb/src/test/java/org/apache/gobblin/metrics/influxdb/TestInfluxDB.java
 
b/gobblin-modules/gobblin-metrics-influxdb/src/test/java/org/apache/gobblin/metrics/influxdb/TestInfluxDB.java
index c02aab2..2870895 100644
--- 
a/gobblin-modules/gobblin-metrics-influxdb/src/test/java/org/apache/gobblin/metrics/influxdb/TestInfluxDB.java
+++ 
b/gobblin-modules/gobblin-metrics-influxdb/src/test/java/org/apache/gobblin/metrics/influxdb/TestInfluxDB.java
@@ -133,7 +133,7 @@ public class TestInfluxDB implements InfluxDB {
    * Get a metric with a given name.
    *
    * @param name metric name
-   * @return a {@link org.apache.gobblin.metrics.TimestampedValue}
+   * @return a {@link org.apache.gobblin.metrics.test.TimestampedValue}
    */
   public TimestampedValue getMetric(String name) {
     return this.data.get(name);

Reply via email to