[incubator-gobblin] branch master updated: [GOBBLIN-837] refactor FlowConfigV2Client and FlowStatusClient to allow child class…

[suvasude]

This is an automated email from the ASF dual-hosted git repository.

suvasude pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new ae7a961  [GOBBLIN-837] refactor FlowConfigV2Client and 
FlowStatusClient to allow child class…
ae7a961 is described below

commit ae7a96163b2e34c96dceae6ce06722e2f9b63d56
Author: Arjun <ab...@linkedin.com>
AuthorDate: Wed Jul 31 06:14:08 2019 -0700

    [GOBBLIN-837] refactor FlowConfigV2Client and FlowStatusClient to allow 
child class…
    
    Closes #2696 from arjun4084346/persistDag
---
 .../main/java/org/apache/gobblin/service/FlowConfigClient.java | 10 ++++++++--
 .../java/org/apache/gobblin/service/FlowConfigV2Client.java    | 10 +++++++---
 .../main/java/org/apache/gobblin/service/FlowStatusClient.java |  8 ++++++--
 3 files changed, 21 insertions(+), 7 deletions(-)

diff --git 
a/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowConfigClient.java
 
b/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowConfigClient.java
index a1c983e..7fed2d1 100644
--- 
a/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowConfigClient.java
+++ 
b/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowConfigClient.java
@@ -65,7 +65,7 @@ public class FlowConfigClient implements Closeable {
     Client r2Client = new 
TransportClientAdapter(_httpClientFactory.get().getClient(Collections.<String, 
String>emptyMap()));
     _restClient = Optional.of(new RestClient(r2Client, serverUri));
 
-    _flowconfigsRequestBuilders = new FlowconfigsRequestBuilders();
+    _flowconfigsRequestBuilders = createRequestBuilders();
   }
 
   /**
@@ -78,7 +78,13 @@ public class FlowConfigClient implements Closeable {
     _httpClientFactory = Optional.absent();
     _restClient = Optional.of(restClient);
 
-    _flowconfigsRequestBuilders = new FlowconfigsRequestBuilders();
+    _flowconfigsRequestBuilders = createRequestBuilders();
+  }
+
+  // Clients using different service name can override this method
+  // RequestBuilders decide the name of the service requests go to.
+  protected FlowconfigsRequestBuilders createRequestBuilders() {
+    return new FlowconfigsRequestBuilders();
   }
 
   /**
diff --git 
a/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowConfigV2Client.java
 
b/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowConfigV2Client.java
index d1e146a..9835245 100644
--- 
a/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowConfigV2Client.java
+++ 
b/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowConfigV2Client.java
@@ -71,8 +71,7 @@ public class FlowConfigV2Client implements Closeable {
     _httpClientFactory = Optional.of(new HttpClientFactory());
     Client r2Client = new 
TransportClientAdapter(_httpClientFactory.get().getClient(Collections.<String, 
String>emptyMap()));
     _restClient = Optional.of(new RestClient(r2Client, serverUri));
-
-    _flowconfigsV2RequestBuilders = new FlowconfigsV2RequestBuilders();
+    _flowconfigsV2RequestBuilders = createRequestBuilders();
   }
 
   /**
@@ -84,8 +83,13 @@ public class FlowConfigV2Client implements Closeable {
 
     _httpClientFactory = Optional.absent();
     _restClient = Optional.of(restClient);
+    _flowconfigsV2RequestBuilders = createRequestBuilders();
+  }
 
-    _flowconfigsV2RequestBuilders = new FlowconfigsV2RequestBuilders();
+  // Clients using different service name can override this method
+  // RequestBuilders decide the name of the service requests go to.
+  protected FlowconfigsV2RequestBuilders createRequestBuilders() {
+    return new FlowconfigsV2RequestBuilders();
   }
 
   /**
diff --git 
a/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowStatusClient.java
 
b/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowStatusClient.java
index 749ec01..08a9fbe 100644
--- 
a/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowStatusClient.java
+++ 
b/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowStatusClient.java
@@ -63,7 +63,7 @@ public class FlowStatusClient implements Closeable {
     Client r2Client = new 
TransportClientAdapter(_httpClientFactory.get().getClient(Collections.<String, 
String>emptyMap()));
     _restClient = Optional.of(new RestClient(r2Client, serverUri));
 
-    _flowstatusesRequestBuilders = new FlowstatusesRequestBuilders();
+    _flowstatusesRequestBuilders = createRequestBuilders();
   }
 
   /**
@@ -76,7 +76,11 @@ public class FlowStatusClient implements Closeable {
     _httpClientFactory = Optional.absent();
     _restClient = Optional.of(restClient);
 
-    _flowstatusesRequestBuilders = new FlowstatusesRequestBuilders();
+    _flowstatusesRequestBuilders = createRequestBuilders();
+  }
+
+  protected FlowstatusesRequestBuilders createRequestBuilders() {
+    return new FlowstatusesRequestBuilders();
   }
 
   /**