jdaugherty commented on code in PR #14093:
URL: https://github.com/apache/grails-core/pull/14093#discussion_r2021069063
##########
gradle/assemble-root-config.gradle:
##########
@@ -5,40 +5,23 @@ import org.grails.gradle.GrailsBuildPlugin
apply plugin: GrailsBuildPlugin
-List<Configuration> libsConfigurations = []
-subprojects { subproject ->
- if (subproject.name == 'grails-shell') {
- libsConfigurations << configurations.create("${subproject.name}-libs")
{
- extendsFrom configurations.runtimeClasspath
- }
+tasks.register('collectCliDependencies') {
+ ext {
+ baseCachesDir = "$gradle.gradleUserHomeDir/caches"
+ cacheDir = "$baseCachesDir/modules-2"
+ metadata = "$cacheDir/metadata-2.1/descriptors"
}
-}
-
-tasks.register('configurePopulateDependencies') {
- ext.set('baseCachesDir', "$gradle.gradleUserHomeDir/caches")
- ext.set('cacheDir', "$baseCachesDir/modules-2")
- ext.set('metadata', "$cacheDir/metadata-2.1/descriptors")
doLast {
- def projectNames = rootProject.subprojects*.name
+ def projectNames = subprojects*.name
def seen = []
- libsConfigurations.each { configuration ->
- configuration.exclude(group: 'org.codehaus.groovy')
- def sourceArtifacts =
sourcesFor(configuration).resolvedConfiguration.lenientConfiguration.artifacts.groupBy
{
- it.moduleVersion.id
- }
- def javadocArtifacts =
javadocFor(configuration).resolvedConfiguration.lenientConfiguration.artifacts.groupBy
{
- it.moduleVersion.id
- }
- def pomArtifacts =
pomFor(configuration).resolvedConfiguration.lenientConfiguration.artifacts.groupBy
{
- it.moduleVersion.id
- }
-
- for (artifact in
configuration.resolvedConfiguration.resolvedArtifacts) {
+ project(':grails-shell').configurations.cli.with {
+ exclude(group: 'org.codehaus.groovy')
Review Comment:
Since these are compiled with the groovy version of gradle, this is ok for
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@grails.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
