jdaugherty commented on code in PR #14093:
URL: https://github.com/apache/grails-core/pull/14093#discussion_r2022807149
##########
gradle/java-config.gradle:
##########
@@ -0,0 +1,19 @@
+compileJava.options.release = javaVersion.toInteger()
+
+tasks.withType(GroovyCompile).configureEach {
+ groovyOptions.encoding = 'UTF-8'
+ options.encoding = 'UTF-8'
+ options.fork = true
+ options.forkOptions.jvmArgs = ['-Xms128M', '-Xmx1G']
+}
+
+tasks.withType(Jar).configureEach {
Review Comment:
I agree with keeping the attributes, but I do think they should be moved to
the project that needs them (bootstrap). I opened
https://github.com/apache/grails-core/issues/14098 to address this after
publishing is working.
##########
gradle/java-config.gradle:
##########
@@ -0,0 +1,19 @@
+compileJava.options.release = javaVersion.toInteger()
+
+tasks.withType(GroovyCompile).configureEach {
+ groovyOptions.encoding = 'UTF-8'
+ options.encoding = 'UTF-8'
+ options.fork = true
+ options.forkOptions.jvmArgs = ['-Xms128M', '-Xmx1G']
+}
+
+tasks.withType(Jar).configureEach {
Review Comment:
I agree with keeping the attributes, but I do think they should be moved to
the project that needs them (bootstrap). I opened
https://github.com/apache/grails-core/issues/14098 to address this after
publishing is working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
