jamesfredley commented on code in PR #554:
URL: https://github.com/apache/grails-forge/pull/554#discussion_r2051593004
##########
grails-forge-core/src/main/java/org/grails/forge/feature/grails/GrailsBase.java:
##########
@@ -54,29 +54,29 @@ public void apply(GeneratorContext generatorContext) {
// This ensures that grails-bom forces milestones to override snapshots
generatorContext.addDependency(Dependency.builder()
- .groupId("org.grails")
+ .groupId("org.apache.grails")
.artifactId("grails-bom")
.pom(true)
.version("$grailsVersion")
.implementation());
generatorContext.addBuildscriptDependency(Dependency.builder()
- .groupId("org.grails")
+ .groupId("org.apache.grails")
.artifactId("grails-bom")
.pom(true)
.version("$grailsVersion")
.classpath());
generatorContext.addDependency(Dependency.builder()
- .groupId("org.grails")
+ .groupId("org.apache.grails")
.artifactId("grails-core")
.implementation());
generatorContext.addDependency(Dependency.builder()
- .groupId("org.grails")
+ .groupId("org.apache.grails.web")
.artifactId("grails-web-boot")
Review Comment:
It was published in `org.apache.grails.web` and not in `org.apache.grails`.
I did update the readme, but if the intent was for it to be in
`org.apache.grails` lets fix all the locations in grails-core, republish and
then I will change it here and on profiles.
grails-forge and profiles were good sanity checks for the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
