jdaugherty commented on code in PR #554:
URL: https://github.com/apache/grails-forge/pull/554#discussion_r2051596093
##########
grails-forge-core/src/main/java/org/grails/forge/feature/grails/GrailsBase.java:
##########
@@ -54,29 +54,29 @@ public void apply(GeneratorContext generatorContext) {
// This ensures that grails-bom forces milestones to override snapshots
generatorContext.addDependency(Dependency.builder()
- .groupId("org.grails")
+ .groupId("org.apache.grails")
.artifactId("grails-bom")
.pom(true)
.version("$grailsVersion")
.implementation());
generatorContext.addBuildscriptDependency(Dependency.builder()
- .groupId("org.grails")
+ .groupId("org.apache.grails")
.artifactId("grails-bom")
.pom(true)
.version("$grailsVersion")
.classpath());
generatorContext.addDependency(Dependency.builder()
- .groupId("org.grails")
+ .groupId("org.apache.grails")
.artifactId("grails-core")
.implementation());
generatorContext.addDependency(Dependency.builder()
- .groupId("org.grails")
+ .groupId("org.apache.grails.web")
.artifactId("grails-web-boot")
Review Comment:
The goal was to have ender users only include stuff from org.apache.grails
unless they're overriding core functionality. So yeah, it's a mistake. We
should remove the .web.
I can do this in the geb PR on monday if that's ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
