matrei commented on code in PR #190: URL: https://github.com/apache/grails-redis/pull/190#discussion_r2224603340
########## plugin/src/test/groovy/grails/plugins/redis/RedisServiceSpec.groovy: ########## @@ -33,6 +34,7 @@ import java.util.concurrent.* import static grails.plugins.redis.RedisService.NO_EXPIRATION_TTL @Integration +@SpringBootTest Review Comment: The `@Integration` annotation adds the `@SpringBootTest` annotation with param `webEnvironment = RANDOM_PORT`. In this case where it is integration tests and not functional tests, we don't need a real web environment. Adding `@SpringBootTest` will replace the one from `@Integration` and use it's default `webEnvironment = MOCK`. We should probably add a param to `@Integration` to be able to set this directly on `@Integration` instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
