matrei commented on code in PR #190: URL: https://github.com/apache/grails-redis/pull/190#discussion_r2226278493
########## plugin/src/test/groovy/grails/plugins/redis/RedisServiceSpec.groovy: ########## @@ -33,6 +34,7 @@ import java.util.concurrent.* import static grails.plugins.redis.RedisService.NO_EXPIRATION_TTL @Integration +@SpringBootTest Review Comment: > We effectively made these unit tests by using the MOCK type, and yet they're in the integration test. We really should move these tests if they're going to remain as a unit test. No, these are integration tests that require a running Redis server and an injected configured `RedisService`. But they are actually located in `src/test`. Looks like apache/grails-redis@d51909d7dc9325d3aa4dfbcd3ea191dbc65f3cdf moved it to the `src/test` folder when updating the project for Grails 3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
