jdaugherty commented on PR #1144:
URL:
https://github.com/apache/grails-spring-security/pull/1144#issuecomment-3108619587
On the geb configuration, I was talking about this code:
systemProperty 'grails.geb.reporting.directory',
reporting.file("$project.projectDir/build/geb-reports").canonicalFile.absolutePath
// systemProperty 'grails.geb.recording.mode', 'RECORD_ALL'
For the functional tests, we should be testing with the same dependencies
that end applications will use. From what I can tell, there has been
divergence from a generated application and the applications in this project.
For the plugin-config.gradle, that's only applied to the plugins. I think
we should turn the Spring Dependency Management gradle plugin off in the
functional test apps because it can cause us to unknowingly pull from a repo
instead of use the local projects. This happened multiple times in the
grails-core merge, and the only reason we caught it was because we were
changing coordinates. Using gradle platforms guarantees we pull dependencies
from the local project and never from a configure repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
