jdaugherty commented on code in PR #1144:
URL:
https://github.com/apache/grails-spring-security/pull/1144#discussion_r2223571471
##########
buildSrc/build.gradle:
##########
@@ -57,7 +57,9 @@ dependencies {
implementation
"org.nosphere.apache.rat:org.nosphere.apache.rat.gradle.plugin:${versions.get('ratVersion')}"
implementation
"org.gradle.crypto.checksum:org.gradle.crypto.checksum.gradle.plugin:${versions.get('gradleCryptoChecksumVersion')}"
- testImplementation 'org.spockframework:spock-core'
+ testImplementation 'org.spockframework:spock-core', {
+ exclude(group: 'org.codehaus.groovy') // Use Gradle provided version
because: Could not resolve org.codehaus.groovy:groovy:3.0.12
Review Comment:
Why do we include test frameworks in build src? This would be groovy 3
which is what the gradle-bom includes. Is this a mistake? If the buildSrc has
tests then we would want to use groovy 3 since groovy 3 is what gradle will use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
