This is an automated email from the ASF dual-hosted git repository. borinquenkid pushed a commit to branch 8.0.x-hibernate7 in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit 21ae29cb9a165384d2fca6489810f3206405775a Author: Walter Duque de Estrada <[email protected]> AuthorDate: Thu Feb 26 17:45:03 2026 -0600 Fix PMD issue in CompositeIdentifierToManyToOneBinder --- grails-data-hibernate7/PMD.md | 2 +- .../binder/CompositeIdentifierToManyToOneBinder.java | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/grails-data-hibernate7/PMD.md b/grails-data-hibernate7/PMD.md index 3dfd86b42f..100bd5e681 100644 --- a/grails-data-hibernate7/PMD.md +++ b/grails-data-hibernate7/PMD.md @@ -158,7 +158,7 @@ DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.Compon DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.ComponentBinder,69,YES DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.ComponentBinder,70,YES DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.CompositeIdBinder,69, -DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.CompositeIdentifierToManyToOneBinder,85, +DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.CompositeIdentifierToManyToOneBinder,85,YES DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.DiscriminatorPropertyBinder,68, DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.DiscriminatorPropertyBinder,68, DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.GrailsDomainBinder,227, diff --git a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/CompositeIdentifierToManyToOneBinder.java b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/CompositeIdentifierToManyToOneBinder.java index ec69e59251..ac117cbedb 100644 --- a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/CompositeIdentifierToManyToOneBinder.java +++ b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/CompositeIdentifierToManyToOneBinder.java @@ -68,6 +68,7 @@ public class CompositeIdentifierToManyToOneBinder { new SimpleValueBinder(metadataBuildingContext, namingStrategy, jdbcEnvironment)); } + @SuppressWarnings("PMD.DataflowAnomalyAnalysis") public void bindCompositeIdentifierToManyToOne( HibernatePersistentProperty property, SimpleValue value, @@ -84,7 +85,7 @@ public class CompositeIdentifierToManyToOneBinder { if (i != expectedForeignKeyColumnLength) { int j = 0; for (String propertyName : propertyNames) { - ColumnConfig cc; + final ColumnConfig cc; // if a column configuration exists in the mapping use it if (j < i) { cc = columns.get(j++); @@ -123,9 +124,9 @@ public class CompositeIdentifierToManyToOneBinder { backticksRemover.apply(compositeIdPrefix) + UNDERSCORE + backticksRemover.apply(suffix); - cc = new ColumnConfig(); - cc.setName(finalColumnName); - columns.add(cc); + ColumnConfig newCc = new ColumnConfig(); + newCc.setName(finalColumnName); + columns.add(newCc); } continue; }
