This is an automated email from the ASF dual-hosted git repository. borinquenkid pushed a commit to branch 8.0.x-hibernate7 in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit adda855324327754532201c4ee7a4504435180da Author: Walter Duque de Estrada <[email protected]> AuthorDate: Thu Feb 26 17:14:14 2026 -0600 Fix PMD issues in ColumnBinder --- grails-data-hibernate7/PMD.md | 16 ++++++++-------- .../hibernate/cfg/domainbinding/binder/ColumnBinder.java | 8 ++++---- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/grails-data-hibernate7/PMD.md b/grails-data-hibernate7/PMD.md index 89882b0687..359fef5df2 100644 --- a/grails-data-hibernate7/PMD.md +++ b/grails-data-hibernate7/PMD.md @@ -146,14 +146,14 @@ DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.MappingCacheHolder,65,YES DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.ClassPropertiesBinder,72,YES DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.CollectionBinder,228,YES DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.CollectionBinder,229,YES -NullAssignment,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,80, -NullAssignment,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,81, -NullAssignment,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,82, -NullAssignment,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,83, -NullAssignment,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,84, -DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,139, -DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,139, -DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,139, +NullAssignment,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,80,YES +NullAssignment,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,81,YES +NullAssignment,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,82,YES +NullAssignment,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,83,YES +NullAssignment,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,84,YES +DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,139,YES +DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,139,YES +DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.ColumnBinder,139,YES DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.ComponentBinder,68, DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.ComponentBinder,69, DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.ComponentBinder,70, diff --git a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ColumnBinder.java b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ColumnBinder.java index d463b275cc..c3675d8740 100644 --- a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ColumnBinder.java +++ b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ColumnBinder.java @@ -36,6 +36,7 @@ import org.hibernate.mapping.Table; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +@SuppressWarnings("PMD.NullAssignment") public class ColumnBinder { private static final Logger LOG = LoggerFactory.getLogger(ColumnBinder.class); @@ -93,6 +94,7 @@ public class ColumnBinder { * @param path * @param table The table name */ + @SuppressWarnings("PMD.DataflowAnomalyAnalysis") public void bindColumn( HibernatePersistentProperty property, HibernatePersistentProperty parentProperty, @@ -135,17 +137,15 @@ public class ColumnBinder { column.setName(columnName); column.setNullable( property.isNullable() || (parentProperty != null && parentProperty.isNullable())); - // We'll reuse the same PropertyConfig for any constraints and uniqueness - PropertyConfig mappedForm = null; // Use the constraints for this property to more accurately define // the column's length, precision, and scale Class<?> type = property.getType(); if (type != null && (String.class.isAssignableFrom(type) || byte[].class.isAssignableFrom(type))) { - mappedForm = property.getMappedForm(); + PropertyConfig mappedForm = property.getMappedForm(); stringColumnConstraintsBinder.bindStringColumnConstraints(column, mappedForm); } else if (type != null && Number.class.isAssignableFrom(type)) { - mappedForm = property.getMappedForm(); + PropertyConfig mappedForm = property.getMappedForm(); numericColumnConstraintsBinder.bindNumericColumnConstraints(column, cc, mappedForm); } }
