This is an automated email from the ASF dual-hosted git repository. borinquenkid pushed a commit to branch 8.0.x-hibernate7 in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit 049fef07dd712a1dbb5d97f7d6be245c95ce52e7 Author: Walter Duque de Estrada <[email protected]> AuthorDate: Thu Feb 26 18:48:20 2026 -0600 Fix PMD issues in HibernateMappingContextConfiguration --- grails-data-hibernate7/PMD.md | 20 ++++++++++---------- .../cfg/HibernateMappingContextConfiguration.java | 10 +++++----- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/grails-data-hibernate7/PMD.md b/grails-data-hibernate7/PMD.md index 36974ff5ec..a9cefaf88a 100644 --- a/grails-data-hibernate7/PMD.md +++ b/grails-data-hibernate7/PMD.md @@ -3,16 +3,16 @@ CloseResource,org.grails.orm.hibernate.cfg.GrailsHibernateUtil,84,YES CloseResource,org.grails.orm.hibernate.cfg.GrailsHibernateUtil,108,YES CloseResource,org.grails.orm.hibernate.cfg.GrailsHibernateUtil,113,YES DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.GrailsHibernateUtil,120,YES -UseProperClassLoader,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,116, -UseProperClassLoader,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,137, -DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,190, -DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,195, -UseProperClassLoader,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,197, -UseProperClassLoader,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,249, -DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,254, -DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,275, -CloseResource,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,290, -CloseResource,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,315, +UseProperClassLoader,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,116,YES +UseProperClassLoader,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,137,YES +DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,190,YES +DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,195,YES +UseProperClassLoader,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,197,YES +UseProperClassLoader,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,249,YES +DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,254,YES +DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,275,YES +CloseResource,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,290,YES +CloseResource,org.grails.orm.hibernate.cfg.HibernateMappingContextConfiguration,315,YES DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.ClassPropertiesBinder,72, DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.CollectionBinder,228, DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.binder.CollectionBinder,229, diff --git a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/HibernateMappingContextConfiguration.java b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/HibernateMappingContextConfiguration.java index 81420e3716..12011f907c 100644 --- a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/HibernateMappingContextConfiguration.java +++ b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/HibernateMappingContextConfiguration.java @@ -187,14 +187,14 @@ public class HibernateMappingContextConfiguration extends Configuration */ public void scanPackages(String... packagesToScan) throws HibernateException { try { + MetadataReaderFactory readerFactory = + new CachingMetadataReaderFactory(resourcePatternResolver); for (String pkg : packagesToScan) { String pattern = ResourcePatternResolver.CLASSPATH_ALL_URL_PREFIX + ClassUtils.convertClassNameToResourcePath(pkg) + RESOURCE_PATTERN; Resource[] resources = resourcePatternResolver.getResources(pattern); - MetadataReaderFactory readerFactory = - new CachingMetadataReaderFactory(resourcePatternResolver); for (Resource resource : resources) { if (resource.isReadable()) { MetadataReader reader = readerFactory.getMetadataReader(resource); @@ -318,13 +318,13 @@ public class HibernateMappingContextConfiguration extends Configuration createStandardServiceRegistryBuilder(bootstrapServiceRegistry) .applySettings(getProperties()); - StandardServiceRegistry serviceRegistry = standardServiceRegistryBuilder.build(); + StandardServiceRegistry ssr = standardServiceRegistryBuilder.build(); try { - sessionFactory = super.buildSessionFactory(serviceRegistry); + sessionFactory = super.buildSessionFactory(ssr); } catch (Exception e) { throw new RuntimeException(e); } - this.serviceRegistry = serviceRegistry; + this.serviceRegistry = ssr; return sessionFactory; }
