This is an automated email from the ASF dual-hosted git repository. borinquenkid pushed a commit to branch 8.0.x-hibernate7 in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit 2b878c79d1df6066ad69252554f16eadf1250615 Author: Walter Duque de Estrada <[email protected]> AuthorDate: Fri Feb 27 08:46:49 2026 -0600 Fix PMD issues in JpaFromProvider --- grails-data-hibernate7/PMD.md | 10 +++++----- .../groovy/org/grails/orm/hibernate/query/JpaFromProvider.java | 5 ++++- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/grails-data-hibernate7/PMD.md b/grails-data-hibernate7/PMD.md index 856e16f855..196d2ae100 100644 --- a/grails-data-hibernate7/PMD.md +++ b/grails-data-hibernate7/PMD.md @@ -91,11 +91,11 @@ AvoidCatchingThrowable,org.grails.orm.hibernate.connections.HibernateConnectionS CloseResource,org.grails.orm.hibernate.connections.HibernateConnectionSourceFactory,256,YES DataflowAnomalyAnalysis,org.grails.orm.hibernate.connections.HibernateConnectionSourceFactory,298,YES DataflowAnomalyAnalysis,org.grails.orm.hibernate.query.JpaCriteriaQueryCreator,131,YES -DataflowAnomalyAnalysis,org.grails.orm.hibernate.query.JpaFromProvider,62, -AvoidLiteralsInIfCondition,org.grails.orm.hibernate.query.JpaFromProvider,150, -ProperCloneImplementation,org.grails.orm.hibernate.query.JpaFromProvider,162, -CloneMethodReturnTypeMustMatchClassName,org.grails.orm.hibernate.query.JpaFromProvider,162, -CloneThrowsCloneNotSupportedException,org.grails.orm.hibernate.query.JpaFromProvider,162, +DataflowAnomalyAnalysis,org.grails.orm.hibernate.query.JpaFromProvider,62,YES +AvoidLiteralsInIfCondition,org.grails.orm.hibernate.query.JpaFromProvider,150,YES +ProperCloneImplementation,org.grails.orm.hibernate.query.JpaFromProvider,162,YES +CloneMethodReturnTypeMustMatchClassName,org.grails.orm.hibernate.query.JpaFromProvider,162,YES +CloneThrowsCloneNotSupportedException,org.grails.orm.hibernate.query.JpaFromProvider,162,YES MissingSerialVersionUID,org.grails.orm.hibernate.query.PagedResultList,31, AvoidAccessibilityAlteration,org.grails.orm.hibernate.support.ClosureEventListener,143, AvoidAccessibilityAlteration,org.grails.orm.hibernate.support.ClosureEventListener,145, diff --git a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/query/JpaFromProvider.java b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/query/JpaFromProvider.java index d378b55340..ee864bd360 100644 --- a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/query/JpaFromProvider.java +++ b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/query/JpaFromProvider.java @@ -35,8 +35,11 @@ import java.util.stream.Stream; import org.grails.datastore.gorm.query.criteria.DetachedAssociationCriteria; import org.hibernate.query.criteria.JpaCriteriaQuery; +@SuppressWarnings({"PMD.DataflowAnomalyAnalysis", "PMD.ProperCloneImplementation", "PMD.CloneMethodReturnTypeMustMatchClassName", "PMD.CloneThrowsCloneNotSupportedException"}) public class JpaFromProvider implements Cloneable { + private static final int SINGLE_PROPERTY = 1; + private final Map<String, From<?, ?>> fromMap; private JpaFromProvider(Map<String, From<?, ?>> fromMap) { @@ -147,7 +150,7 @@ public class JpaFromProvider implements Cloneable { throw new IllegalArgumentException("propertyName cannot be null"); } String[] parsed = propertyName.split("\\."); - if (parsed.length == 1) { + if (parsed.length == SINGLE_PROPERTY) { if (fromMap.containsKey(propertyName)) { return fromMap.get(propertyName); } else {
