This is an automated email from the ASF dual-hosted git repository. borinquenkid pushed a commit to branch 8.0.x-hibernate7 in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit 473c1690da89f96c236b39449bfa777678e5c4da Author: Walter Duque de Estrada <[email protected]> AuthorDate: Fri Feb 27 08:37:05 2026 -0600 Fix PMD issues in UniqueNameGenerator --- grails-data-hibernate7/PMD.md | 2 +- .../orm/hibernate/cfg/domainbinding/util/UniqueNameGenerator.java | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/grails-data-hibernate7/PMD.md b/grails-data-hibernate7/PMD.md index c2736f15b0..6b45688d76 100644 --- a/grails-data-hibernate7/PMD.md +++ b/grails-data-hibernate7/PMD.md @@ -83,7 +83,7 @@ DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.util.TableFor DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.util.TableForManyCalculator,59,YES DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.util.TableForManyCalculator,61,YES DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.util.TableForManyCalculator,92,YES -AvoidLiteralsInIfCondition,org.grails.orm.hibernate.cfg.domainbinding.util.UniqueNameGenerator,51, +AvoidLiteralsInIfCondition,org.grails.orm.hibernate.cfg.domainbinding.util.UniqueNameGenerator,51,YES CloseResource,org.grails.orm.hibernate.connections.HibernateConnectionSource,53, CloseResource,org.grails.orm.hibernate.connections.HibernateConnectionSourceFactory,109, CloseResource,org.grails.orm.hibernate.connections.HibernateConnectionSourceFactory,172, diff --git a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/util/UniqueNameGenerator.java b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/util/UniqueNameGenerator.java index a9c5f13c53..0099708950 100644 --- a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/util/UniqueNameGenerator.java +++ b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/util/UniqueNameGenerator.java @@ -32,6 +32,8 @@ import org.hibernate.mapping.UniqueKey; public class UniqueNameGenerator { + private static final int MAX_LENGTH = 30; + public void setGeneratedUniqueName(@NotNull UniqueKey uk) { if (uk.getTable() == null) { throw new MappingException( @@ -48,8 +50,8 @@ public class UniqueNameGenerator { MessageDigest md = MessageDigest.getInstance("MD5"); md.update(ukString.getBytes(StandardCharsets.UTF_8)); String name = "UK" + new BigInteger(1, md.digest()).toString(16); - if (name.length() > 30) { - name = name.substring(0, 30); + if (name.length() > MAX_LENGTH) { + name = name.substring(0, MAX_LENGTH); } uk.setName(name); } catch (NoSuchAlgorithmException e) {
