bito-code-review[bot] commented on PR #534: URL: https://github.com/apache/grails-static-website/pull/534#issuecomment-5267414936
<!-- Bito Reply --> The concern regarding layout shifts caused by `margin-left: 4px` on focused TOC links is valid. Using properties that affect layout, such as margins or padding, can indeed cause UI jank and shift surrounding elements when focus is applied or removed. To avoid this, consider using non-layout-shifting alternatives for focus styling, such as: * **Outline:** Use the `outline` property, which is drawn outside the element's box model and does not affect layout. * **Box Shadow:** Use `box-shadow` to create a focus ring, which also does not impact the layout of the element or its neighbors. * **Background/Color Changes:** Modify the `background-color` or `color` of the link, which provides visual feedback without changing the element's dimensions. Since the file `guides/resources/css/guide.css` was not found in the provided PR context, please verify the file path or check if the CSS is defined in a different location within the repository. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
