jamesfredley commented on PR #534:
URL:
https://github.com/apache/grails-static-website/pull/534#issuecomment-5347447987
@sanjana2505006 Thank you for the careful review. I learned a lot from going
through these notes.
Addressed:
1. TOC label vs content - agreed. `requirements` is now "What you will
need", matching the other guides and `requirements.adoc`. "What you will build"
stays in `gettingStarted.adoc`.
2. Shared guide chrome / amber `#d97706` headings - yes, intentional
site-wide. Focus, viewport, chapter nav, and print wrapping are the
a11y/responsive bits; the heading color is part of that same chrome pass.
3. Snippet parity - agreed it was worth vendoring.
`JobExamplesControllerSpec` and `JobExamplesServiceSpec` are now in the guide
snippets and called out in the testing chapter.
4. Runbook nits:
- Added `-H "Content-Type: application/x-www-form-urlencoded"` on the
delivery POST.
- Confirmed `xref:operations.adoc#operations` already resolves. The
renderer assigns `id="operations"` to the chapter `<h1>`, so I did not add a
second `[[operations]]` (that would duplicate the id on the first `h2`).
Companion [grails-jobrunr](https://github.com/grails-guides/grails-jobrunr)
already has those specs on `grails8` and has no open PR, so nothing to change
or merge there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
