acezen commented on code in PR #489:
URL: https://github.com/apache/incubator-graphar/pull/489#discussion_r1609787693
##########
cpp/include/graphar/util/filesystem.h:
##########
@@ -35,16 +35,19 @@
namespace arrow {
class Buffer;
class Table;
-namespace fs {
+}// namespace arrow
+
+namespace arrow::fs {
class FileSystem;
-}
-namespace io {
+}// namespace arrow::fs
Review Comment:
Ditto
##########
cpp/include/graphar/util/filesystem.h:
##########
@@ -35,16 +35,19 @@
namespace arrow {
class Buffer;
class Table;
-namespace fs {
+}// namespace arrow
Review Comment:
the correct format is
```suggestion
} // namespace arrow
```
##########
cpp/include/graphar/writer/edges_builder.h:
##########
@@ -426,5 +424,4 @@ class EdgesBuilder {
ValidateLevel validate_level_;
};
-} // namespace builder
-} // namespace graphar
+} // namespace graphar::builder
Review Comment:
Add an empty line in the tail of source file
##########
cpp/src/edges_builder.cc:
##########
@@ -349,5 +348,4 @@ Result<std::shared_ptr<arrow::Table>>
EdgesBuilder::getOffsetTable(
return arrow::Table::Make(schema, arrays);
}
-} // namespace builder
-} // namespace graphar
+} // namespace graphar::builder
Review Comment:
Ditto
##########
cpp/src/util.cc:
##########
@@ -99,5 +97,4 @@ std::string ValueGetter<std::string>::Value(const void* data,
int64_t offset) {
reinterpret_cast<const arrow::LargeStringArray*>(data)->GetView(offset));
}
-} // namespace util
-} // namespace graphar
+} // namespace graphar::util
Review Comment:
Ditto
##########
cpp/include/graphar/util/filesystem.h:
##########
@@ -35,16 +35,19 @@
namespace arrow {
class Buffer;
class Table;
-namespace fs {
+}// namespace arrow
+
+namespace arrow::fs {
class FileSystem;
-}
-namespace io {
+}// namespace arrow::fs
+
+namespace arrow::io {
class RandomAccessFile;
-}
-namespace dataset {
+}// namespace arrow::io
Review Comment:
Ditto
##########
cpp/include/graphar/fwd.h:
##########
@@ -201,12 +201,10 @@ const std::shared_ptr<DataType>& timestamp();
* @param value_type value type of the list
*/
std::shared_ptr<DataType> list(const std::shared_ptr<DataType>& value_type);
-
-namespace util {
+} // namespace graphar
Review Comment:
here should have an empty line?
##########
cpp/include/graphar/util/result.h:
##########
@@ -117,6 +115,4 @@ inline Status GenericToStatus(Result<T>&& res) {
return std::move(res).status();
}
-} // namespace internal
-
-} // namespace graphar
+} // namespace graphar::internal
Review Comment:
here should be an empty line in the last of file
##########
cpp/src/filesystem.cc:
##########
@@ -311,4 +310,4 @@ template Result<IdType> FileSystem::ReadFileToValue<IdType>(
template Status FileSystem::WriteValueToFile<IdType>(const IdType&,
const std::string&) const
noexcept;
-} // namespace graphar
+} // namespace graphar
Review Comment:
Ditto
##########
cpp/src/reader_util.cc:
##########
@@ -206,6 +204,4 @@ Result<IdType> GetEdgeNum(const std::string& prefix,
return edge_num;
}
-} // namespace util
-
-} // namespace graphar
+} // namespace graphar::util
Review Comment:
Ditto
##########
cpp/src/vertices_builder.cc:
##########
@@ -232,5 +231,4 @@ Result<std::shared_ptr<arrow::Table>>
VerticesBuilder::convertToTable() {
return arrow::Table::Make(schema, arrays);
}
-} // namespace builder
-} // namespace graphar
+} // namespace graphar::builder
Review Comment:
Ditto
##########
cpp/include/graphar/writer/vertices_builder.h:
##########
@@ -347,5 +346,4 @@ class VerticesBuilder {
ValidateLevel validate_level_;
};
-} // namespace builder
-} // namespace graphar
+} // namespace graphar::builder
Review Comment:
Ditto
##########
cpp/thirdparty/simple-uri-parser/uri_parser.h:
##########
@@ -89,7 +89,7 @@ struct Uri {
{}
};
-}
+}
Review Comment:
please trim the space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
