acezen commented on code in PR #489:
URL: https://github.com/apache/incubator-graphar/pull/489#discussion_r1609861416
##########
cpp/src/filesystem.cc:
##########
@@ -311,4 +310,4 @@ template Result<IdType> FileSystem::ReadFileToValue<IdType>(
template Status FileSystem::WriteValueToFile<IdType>(const IdType&,
const std::string&) const
noexcept;
-} // namespace graphar
+} // namespace graphar
Review Comment:
better to add empty line to the end of this file.
##########
cpp/src/reader_util.cc:
##########
@@ -206,6 +204,4 @@ Result<IdType> GetEdgeNum(const std::string& prefix,
return edge_num;
}
-} // namespace util
-
-} // namespace graphar
+} // namespace graphar::util
Review Comment:
better to add empty line to the end of this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
