acezen commented on code in PR #535:
URL: https://github.com/apache/incubator-graphar/pull/535#discussion_r1668455953
##########
maven-projects/info/pom.xml:
##########
@@ -42,6 +42,9 @@
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <os.plugin.version>1.6.2</os.plugin.version>
+ <protobuf.plugin.version>0.6.1</protobuf.plugin.version>
+ <protobuf.version>3.21.1</protobuf.version>
Review Comment:
> 1.32.0 is the version of buf, not `protoc`.
>
> Th actual version of protobuf that we are using is `3.27.1`
>
> (explanation: we are on `proto3` syntax and the version of protobuf plugin
for a minor version of `protoc` itself)
>
> I mean, I have a strong feeling, that we need to pin it globally.
Otherwise it may become hard to maintain it in two different places (Maven and
buf.gen.yaml)
agree, we need to unify the protobuf version in project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
