acezen commented on PR #595: URL: https://github.com/apache/incubator-graphar/pull/595#issuecomment-2292977582
> > Do I understand it right, that it is only part of Java refactoring? > > It's basic refactoring for info module. And later on, I will add some unit tests and doc. Seems good, maybe you can add a basic test that construct GraphInfo from current testing dir's graph yaml in this PR. You need to consider how to convert yaml to json and using [JsonFormat](https://protobuf.dev/reference/java/api-docs/com/google/protobuf/util/JsonFormat.html) to parse to protobuf, as we discussed in https://lists.apache.org/thread/o5bqbhxvcbm6xqj1j1m2h7bhdnsvgsoy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
