SemyonSinchenko commented on PR #595: URL: https://github.com/apache/incubator-graphar/pull/595#issuecomment-2292991680
> > Do I understand it right, that it is only part of Java refactoring? > > It's basic refactoring for info module. And later on, I will add some unit tests and doc. My question was because I have concerns about the current implementation. 1. Hadoop dependency. If we want to have a "kernel-like" approach to the Java info classes, do we really need Hadoop as a dependency? 3. `load` and `save` methods: load is static and cannot be re-defined, save is Hadoop based; 4. Do we really need a wrapper for each of proto object? I was thinking maybe we can work directly with proto-classes and provide only an additional functionality (like save, load, etc.)? For example all these methods that just do string concatenations: if anyone wants to implement own GAR-connector based on our classes, it will be hard to re-define all this methods, etc. If this PR is a part of the refactoring let's merge it. But if it is a final state of Java GAR I would like to discuss it little more! Nevertheless it is a very cool work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
