Sober7135 opened a new issue, #846:
URL: https://github.com/apache/incubator-graphar/issues/846

   ### Describe the bug, including details regarding any error messages, 
version, and platform.
   
   1. `graphar::builder::Vertex` provides a default constructor that does not 
initialize `id_`. However, `GetId()` can still be called and may return an 
uninitialized value, which is undefined behavior.
   
   
https://github.com/apache/incubator-graphar/blob/7bad8ec50f79314b7b9db472ae6e699d27d450f6/cpp/src/graphar/high-level/vertices_builder.h#L52-L68
   
   2. graphar::builder::Vertex also provides `SetId(IdType id)`, but `SetId` 
does not set `empty_` to false. This seems inconsistent with the `Vertex(IdType 
id)` constructor (which sets `empty_ = false`) and is likely not the expected 
behavior.
   
   
https://github.com/apache/incubator-graphar/blob/7bad8ec50f79314b7b9db472ae6e699d27d450f6/cpp/src/graphar/high-level/vertices_builder.h#L70-L75
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to